Skip to content
This repository was archived by the owner on Feb 11, 2025. It is now read-only.

Throw json parse exception on empty string #474

Merged
merged 2 commits into from
Dec 30, 2022
Merged

Throw json parse exception on empty string #474

merged 2 commits into from
Dec 30, 2022

Conversation

rutgersc
Copy link
Contributor

Fix #473

@leastprivilege leastprivilege self-assigned this Dec 15, 2022
@leastprivilege leastprivilege merged commit 35d3401 into DuendeArchive:main Dec 30, 2022
@leastprivilege
Copy link
Contributor

thanks!

leastprivilege added a commit that referenced this pull request Dec 30, 2022
@leastprivilege
Revert "Throw json parse exception on empty string (#474)"
02d5c09 
This reverts commit 35d3401.
@leastprivilege leastprivilege mentioned this pull request Dec 30, 2022
Merged
leastprivilege added a commit that referenced this pull request Dec 30, 2022
@leastprivilege
Revert "Throw json parse exception on empty string (#474)" (#484)
f9b8c30 
This reverts commit 35d3401.
@leastprivilege
Copy link
Contributor

Some tests are failing - had to revert

@rutgersc
Copy link
Contributor Author

rutgersc commented Jan 6, 2023

I see, my bad! Though I think I found a more sensible way to fix the exception, here's the PR: #487.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leastprivilege leastprivilege Awaiting requested review from leastprivilege

@brockallen brockallen Awaiting requested review from brockallen

Assignees

@leastprivilege leastprivilege

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ProtocolResponse.FromHttpResponseAsync does not treat empty sting as invalid json
2 participants
@rutgersc @leastprivilege