Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow trailing slash in mounted volumes #56

Merged
merged 2 commits into from
Mar 12, 2019
Merged

Conversation

johnbradley
Copy link
Contributor

Fixes #32

@dleehr
Copy link
Member

dleehr commented Mar 12, 2019

@johnbradley is this ready for review?

@johnbradley
Copy link
Contributor Author

johnbradley commented Mar 12, 2019

Almost I just need to run it against openshift.

@johnbradley johnbradley requested a review from dleehr March 12, 2019 19:03
Copy link
Member

@dleehr dleehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice use of os.path.join 👍

@johnbradley johnbradley merged commit 3f9bc13 into master Mar 12, 2019
@johnbradley johnbradley deleted the 33-trailing-slash-fix branch March 12, 2019 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants