Use emptyDir for '/tmp' inside containers #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updates KubernetesVolumeBuilder to support a list of named emptyDir volumes - Updates CalrissianCommandLineJob.create_kubernetes_runtime to use an emptyDir volume for '/tmp' inside the container Upon implementation, I don't think this will conflict with any of the special cases mentioned in #30 (writable files being copied into /tmp). These files are copied on the calrissian host and mounted later (via `add_volumes()`). This change will mount the base `/tmp` as an `emptyDir` but additional direct mounts to files placed by calrissian shouldn't be impacted. Fixes #30
johnbradley
approved these changes
Mar 20, 2019
There was a problem hiding this comment.
LGTM
What purpose does the volume we pass via the calrissian --tmpdir-prefix option serve now?
calrissian/openshift/CalrissianJob-revsort.yaml
Lines 22 to 23 in f5d9185
When using calrissian do we even need to create a "tmpdir" volume and pass it now?
In most cases, no. I'll document the exceptions in an issue, since there's still places it makes sense but it's not typical and not necessary for any of our workflows. Let me update the examples to remove the tmpdir volume claim. |
This volume is no longer needed
|
Discussion about |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon implementation, I don't think this will conflict with any of the special cases mentioned in #30 (writable files being copied into /tmp). These files are copied on the calrissian host and mounted later (via
add_volumes()). This change will mount the base/tmpas anemptyDirbut additional direct mounts to files placed by calrissian shouldn't be impacted.tl;dr - this is a simple fix for #30 that shouldn't break the existing special cases (that we don't use anyway)
Fixes #30