Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updated (dev)Dependencies and node version #18

Merged
merged 1 commit into from
Oct 29, 2019

Conversation

natterstefan
Copy link
Collaborator

FYI: Node 8 reaches EOL on December 2019 (https://github.com/nodejs/Release#release-schedule)

@natterstefan
Copy link
Collaborator Author

@DylanPiercey most likely this should be a breaking change because we change the required node-version. What do you think?

@DylanPiercey
Copy link
Owner

Yeah this should be a major. That is fine with me though.

@natterstefan
Copy link
Collaborator Author

@DylanPiercey perfect, shall we deploy the current unreleased changes with this new major or as a 2.x feature, before creating this major? https://github.com/DylanPiercey/local-devices/blob/master/CHANGES.md#unreleased.

@DylanPiercey
Copy link
Owner

Sorry for the delay. I think let's just go ahead and release the unreleased changes with the next major.

Would you like to do the release?

@natterstefan
Copy link
Collaborator Author

@DylanPiercey easy, then let's do it all together. Sure, I can do it. Do you mean on npm and/or here?

@DylanPiercey
Copy link
Owner

Both 😄

@natterstefan
Copy link
Collaborator Author

:D

Sure, I just need publish rights on npm, please. Here's my user: https://www.npmjs.com/~natterstefan.

@DylanPiercey
Copy link
Owner

Added! Thanks 😄

@natterstefan
Copy link
Collaborator Author

Thank you, will publish it in a few minutes.

@natterstefan natterstefan merged commit a9e5983 into master Oct 29, 2019
@natterstefan natterstefan deleted the feature/1019-update-dependencies branch October 29, 2019 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants