android fixes

DylanVann · Aug 29, 2022 · 5851f85 · 5851f85
1 parent 661462a
commit 5851f85
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 4 deletions.
diff --git a/android/src/main/java/com/dylanvann/fastimage/FastImageOkHttpProgressGlideModule.java b/android/src/main/java/com/dylanvann/fastimage/FastImageOkHttpProgressGlideModule.java
@@ -32,7 +32,7 @@
 @GlideModule
 public class FastImageOkHttpProgressGlideModule extends LibraryGlideModule {
 
-    private static DispatchingProgressListener progressListener = new DispatchingProgressListener();
+    private static final DispatchingProgressListener progressListener = new DispatchingProgressListener();
 
     @Override
     public void registerComponents(

diff --git a/android/src/main/java/com/dylanvann/fastimage/FastImageSource.java b/android/src/main/java/com/dylanvann/fastimage/FastImageSource.java
@@ -17,7 +17,7 @@ public class FastImageSource extends ImageSource {
     private static final String ANDROID_RESOURCE_SCHEME = "android.resource";
     private static final String ANDROID_CONTENT_SCHEME = "content";
     private static final String LOCAL_FILE_SCHEME = "file";
-    private Headers mHeaders;
+    private final Headers mHeaders;
     private Uri mUri;
 
     public static boolean isBase64Uri(Uri uri) {

diff --git a/android/src/main/java/com/dylanvann/fastimage/FastImageViewModule.java b/android/src/main/java/com/dylanvann/fastimage/FastImageViewModule.java
@@ -2,6 +2,8 @@
 
 import android.app.Activity;
 
+import androidx.annotation.NonNull;
+
 import com.bumptech.glide.Glide;
 import com.bumptech.glide.load.model.GlideUrl;
 import com.facebook.react.bridge.Promise;
@@ -20,6 +22,7 @@ class FastImageViewModule extends ReactContextBaseJavaModule {
         super(reactContext);
     }
 
+    @NonNull
     @Override
     public String getName() {
         return REACT_CLASS;

diff --git a/android/src/main/java/com/dylanvann/fastimage/FastImageViewPackage.java b/android/src/main/java/com/dylanvann/fastimage/FastImageViewPackage.java
@@ -1,5 +1,7 @@
 package com.dylanvann.fastimage;
 
+import androidx.annotation.NonNull;
+
 import com.facebook.react.ReactPackage;
 import com.facebook.react.bridge.NativeModule;
 import com.facebook.react.bridge.ReactApplicationContext;
@@ -9,13 +11,15 @@
 import java.util.List;
 
 public class FastImageViewPackage implements ReactPackage {
+    @NonNull
     @Override
-    public List<NativeModule> createNativeModules(ReactApplicationContext reactContext) {
+    public List<NativeModule> createNativeModules(@NonNull ReactApplicationContext reactContext) {
         return Collections.<NativeModule>singletonList(new FastImageViewModule(reactContext));
     }
 
+    @NonNull
     @Override
-    public List<ViewManager> createViewManagers(ReactApplicationContext reactContext) {
+    public List<ViewManager> createViewManagers(@NonNull ReactApplicationContext reactContext) {
         return Collections.<ViewManager>singletonList(new FastImageViewManager());
     }
 }