-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translations into V4 #72
Conversation
yay pylint doesn't hate me anymore! |
Do you have an ETA on this pull request @Soapy7261? |
I mean i kinda want your feedback on what to add, since it could already be added but it probably shouldn't |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fine to me. I haven't tested it yet and i don't see the need to because the code is clearly functional. Though I'd like to ask that you add indentation between each respective function and test, because this looks a bit awkward otherwise.
I will most likely mend the code after it is pushed to work with user/guild database settings, but that should not take much work with an understanding of Rebel's systems. You can mark this as ready for review after changing the indentation if you wish, and then i will pull it.
That should be what you want, right? |
WIP