Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations into V4 #72

Merged
merged 5 commits into from
Aug 9, 2024
Merged

Translations into V4 #72

merged 5 commits into from
Aug 9, 2024

Conversation

Soapy7261
Copy link
Contributor

WIP

@Soapy7261 Soapy7261 requested a review from JoshuaSlui August 1, 2024 01:12
@Soapy7261
Copy link
Contributor Author

yay pylint doesn't hate me anymore!

@JoshuaSlui
Copy link
Member

Do you have an ETA on this pull request @Soapy7261?

@Soapy7261
Copy link
Contributor Author

Soapy7261 commented Aug 8, 2024

I mean i kinda want your feedback on what to add, since it could already be added but it probably shouldn't

Copy link
Member

@JoshuaSlui JoshuaSlui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to me. I haven't tested it yet and i don't see the need to because the code is clearly functional. Though I'd like to ask that you add indentation between each respective function and test, because this looks a bit awkward otherwise.

I will most likely mend the code after it is pushed to work with user/guild database settings, but that should not take much work with an understanding of Rebel's systems. You can mark this as ready for review after changing the indentation if you wish, and then i will pull it.

@Soapy7261
Copy link
Contributor Author

That should be what you want, right?

@Soapy7261 Soapy7261 marked this pull request as ready for review August 9, 2024 00:08
providers/translation/get_translate.py Outdated Show resolved Hide resolved
@JoshuaSlui JoshuaSlui merged commit 16935c6 into 4.0.0 Aug 9, 2024
3 checks passed
@JoshuaSlui JoshuaSlui added this to the 4.0.0 milestone Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants