-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DYN-: D7480 update resources in DynamoCoreWpf project - master cl #15781
DYN-: D7480 update resources in DynamoCoreWpf project - master cl #15781
Conversation
I noticed that when compiling the Dynamo solution for most of the projects which contain resources in several languages (like Resources.es-ES.resx ) the ...resources.dll was generated correctly but the DynamoCoreWpf.resources.dll was missing (seems that even when the .resx files are located in \src\DynamoCoreWpf\Properties the resources are not loaded in VS2022). Then I modified the DynamoCoreWpf.csproj adding the resources directly, in that way the DynamoCoreWpf.resources.dll was generated sucessfully in each language folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7480
Just for this case, we cannot add resources for each language by just creating the .resx in the FYI: @avidit @pinzart90 |
UI Smoke TestsTest: success. 11 passed, 0 failed. |
@RobertGlobant20 Can you re run the PR check? |
|
@RobertGlobant20 Thanks! |
Purpose
The DynamoCoreWpf.resources.dll was missing in language folders
I noticed that when compiling the Dynamo solution for most of the projects which contain resources in several languages (like Resources.es-ES.resx ) the ...resources.dll was generated correctly but the DynamoCoreWpf.resources.dll was missing (seems that even when the .resx files are located in \src\DynamoCoreWpf\Properties the resources are not loaded in VS2022).
Then I modified the DynamoCoreWpf.csproj adding the resources directly, in that way the DynamoCoreWpf.resources.dll was generated sucessfully in each language folder.
Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
The DynamoCoreWpf.resources.dll was missing in language folders
Reviewers
@QilongTang
FYIs
@pinzart90