Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-: D7480 update resources in DynamoCoreWpf project - master cl #15781

Conversation

RobertGlobant20
Copy link
Contributor

Purpose

The DynamoCoreWpf.resources.dll was missing in language folders
I noticed that when compiling the Dynamo solution for most of the projects which contain resources in several languages (like Resources.es-ES.resx ) the ...resources.dll was generated correctly but the DynamoCoreWpf.resources.dll was missing (seems that even when the .resx files are located in \src\DynamoCoreWpf\Properties the resources are not loaded in VS2022).
Then I modified the DynamoCoreWpf.csproj adding the resources directly, in that way the DynamoCoreWpf.resources.dll was generated sucessfully in each language folder.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

The DynamoCoreWpf.resources.dll was missing in language folders

Reviewers

@QilongTang

FYIs

@pinzart90

I noticed that when compiling the Dynamo solution for most of the projects which contain resources in several languages (like Resources.es-ES.resx ) the ...resources.dll was generated correctly but the DynamoCoreWpf.resources.dll was missing (seems that even when the .resx files are located in \src\DynamoCoreWpf\Properties the resources are not loaded in VS2022).
Then I modified the DynamoCoreWpf.csproj adding the resources directly, in that way the DynamoCoreWpf.resources.dll was generated sucessfully in each language folder.
@github-actions github-actions bot changed the title D7480 update resources in DynamoCoreWpf project - master cl DYN-: D7480 update resources in DynamoCoreWpf project - master cl Jan 24, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7480

@RobertGlobant20
Copy link
Contributor Author

Just for this case, we cannot add resources for each language by just creating the .resx in the DynamoCoreWpf/Properties folder due that EnableDefaultEmbeddedResourceItems = False (This flag is inside the DynamoCoreWpf.csproj file and disabled auto adding .resx files in the project), this change was done when moving Dynamo from .NET Framework 4.8 to .NET 6/8 due that if the flag is True (by default is True) the project compilation is sending errors related to Duplicated EmbeddedResources (also if the EmbeddedResources is deleted is sending errors in source code related to accessing resources).
So I had to add the .resx files manually using VS2022 in this way the DynamoCoreWpf.resources.dll was created in each language folder.
A new task should be created for removing the EnableDefaultEmbeddedResourceItems and EnableDefaultCompileItems from DynamoCoreWpf.csproj and fix the errors related to resources when compiling the project.

FYI: @avidit @pinzart90

Copy link

UI Smoke Tests

Test: success. 11 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests

@QilongTang
Copy link
Contributor

@RobertGlobant20 Can you re run the PR check?

@RobertGlobant20
Copy link
Contributor Author

@RobertGlobant20 Can you re run the PR check?
@QilongTang
Passed in master-15 DYN-DevCI_Self_Service job
https://master-15.jenkins.autodesk.com/view/DYN/job/DYN-DevCI_Self_Service/1465/

@QilongTang
Copy link
Contributor

@RobertGlobant20 Thanks!

@QilongTang QilongTang merged commit 5b9e37c into DynamoDS:master_cl Jan 27, 2025
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants