Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review transactions #813

Merged
merged 38 commits into from
Dec 28, 2024
Merged

Review transactions #813

merged 38 commits into from
Dec 28, 2024

Conversation

andrykonchin
Copy link
Member

@andrykonchin andrykonchin commented Oct 6, 2024 •
edited
Loading

Changes:

  • changed new public methods to be closer to the existing non-transactional methods
  • removed some transactional methods that don't have non-transactional counterparts or cannot be atomic
  • moved documentation to the main README.md file
  • added more specs

Follow-up for #688 and #718

@andrykonchin andrykonchin marked this pull request as draft October 9, 2024 14:01
@andrykonchin andrykonchin changed the title [WIP] Review transactions Review transactions Oct 9, 2024
@andrykonchin andrykonchin force-pushed the ak/review-transactions branch from 04c4f4c to 83b6d50 Compare October 17, 2024 22:32
@andrykonchin andrykonchin force-pushed the ak/review-transactions branch 3 times, most recently from 851be13 to 3f7e154 Compare November 1, 2024 17:52
@andrykonchin andrykonchin force-pushed the ak/review-transactions branch 3 times, most recently from c42d3c0 to 7a35e94 Compare November 3, 2024 14:34
@codecov Codecov
Copy link

codecov bot commented Nov 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.29684% with 7 lines in your changes missing coverage. Please review.

Project coverage is 91.44%. Comparing base (191ecff) to head (75a55b2).
Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
lib/dynamoid/transaction_write/base.rb 58.82% 7 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #813      +/-   ##
==========================================
+ Coverage   91.18%   91.44%   +0.25%     
==========================================
  Files          73       75       +2     
  Lines        3496     3645     +149     
==========================================
+ Hits         3188     3333     +145     
- Misses        308      312       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrykonchin andrykonchin marked this pull request as ready for review November 3, 2024 14:48
@andrykonchin andrykonchin force-pushed the ak/review-transactions branch from 7a35e94 to 7208702 Compare November 3, 2024 14:57
@andrykonchin andrykonchin force-pushed the ak/review-transactions branch from 75a55b2 to 14a28de Compare December 28, 2024 11:11
@andrykonchin
Add specs roll backs when an issue is detected on the DynamoDB's side
bf91173
@andrykonchin
Remove :skip_existence_check option
5c2ad7e
@andrykonchin
Remove :skip_callbacks and :skip_validation options
298398b
@andrykonchin
Avoid not documented ways to pass parameters in specs
487858b
@andrykonchin
Refactor and add missing specs for transactions
9741f0c
@andrykonchin
Add some missing specs in spec/dynamoid/persistence_spec.rb
77134fc
@andrykonchin
Rename #update(model, attributes) into #update_attributes(model, attr…
7711e9e 
…ibutes)
@andrykonchin
Replace #update(class, attributes) with #update_fields(class, hash_ke…
ffe00c9 
…y, attributes)
@andrykonchin
Remove not supported use cases in README_transact.md
f214d2b
@andrykonchin
Refactor how transactions are implemented
e20e54c
@andrykonchin
Restore commented specs
84cabec
@andrykonchin
Fix model updating when no attributes are specified and no timestamps…
2a4bb5e 
… to update
@andrykonchin
Fix #destroy and return false when execution aborted
7e312f8
@andrykonchin
Fix #destroy! and raise RecordNotDestroyed error when execution aborted
b414795
@andrykonchin
Adjust #destroy/#destroy! to not raise error when an item doesn't exi…
314b4f8 
…st like original #destroy/#destroy! do
@andrykonchin
Adjust #create/#save/#update_attributes to handle aborting and item n…
3a36f7d 
…ot existing properly
@andrykonchin
Add missing specs to check that invalid model after persisting still …
f8462fb 
…not persisted and has changes
@andrykonchin
Add missing specs for #changed? and #persisted? predicated
9b6e4ed
@andrykonchin
Change #upsert signature to accept hash and range keys parameters sep…
55c964e 
…arately
@andrykonchin
Change #delete signature to accept hash and range keys parameters sep…
4b8d57c 
…arately
@andrykonchin
Validate primary key in #save
74ba659
@andrykonchin
Support #save(object, validate: false)
f096d13
@andrykonchin
Persist multiple models in #create/#create!
fc6c57d
@andrykonchin
Accept a block in #create/#create!
df23170
@andrykonchin
Accept touch: false option in #save/#save!
52f3516
@andrykonchin
Assign a model id immediately in #save/#save! so it can be used in ot…
41de670 
…her actions in the same transaction
@andrykonchin
Polish documentation for transactions
bf49ba6
@andrykonchin
Move the documentation for transactions into the main README.md
75def16
@andrykonchin
Skip specs for callback aborting on Rails 4.2
f9abbb6
@andrykonchin
Fix Rubocop warnings
cf9e89a
@andrykonchin
Add after_commit and after_rollback callbacks
1534e28
@andrykonchin
Introduce a base class for actions
c325b17
@andrykonchin
Don't re-raise Rollback exception in case of deliberate rollback.
17bf366
@andrykonchin
Fix transactional #update_fields and #upsert to raise Dynamoid::Error…
67b7fa2 
…s::UnknownAttribute when not declared attribute name is passed
@andrykonchin
Add documentation comments for the TransactionWrite class and its pub…
585f45a 
…lic methods
@andrykonchin
Refactor building TransactWriteItems request
c8cd90e
@andrykonchin
Update Readme.md document and add warning about experimental feature
0583282
@andrykonchin
Fix Rubocop warnings
f9a4994
@andrykonchin andrykonchin force-pushed the ak/review-transactions branch from 96a9884 to f9a4994 Compare December 28, 2024 11:35
@github-actions GitHub Actions
Copy link

Code Coverage

Package Line Rate Health
dynamoid 91% ➖
Summary 91% (3342 / 3654) ➖

Minimum allowed line rate is 90%

@andrykonchin andrykonchin merged commit 312421b into master Dec 28, 2024
57 of 58 checks passed
@andrykonchin andrykonchin deleted the ak/review-transactions branch December 28, 2024 11:46
@andrykonchin
Copy link
Member Author

@ckhsponge

Finally I am ready to release this new transactions API. Thank you for your contribution!

There are still a few small items in my TODO list for the next release so it will take some time.

@ckhsponge
Copy link
Contributor

@andrykonchin I'm looking forward to it! I have some projects running now that use transactions and I'd be happy to test a release candidate if you want.

@andrykonchin
Copy link
Member Author

Yeah, it will be great!

@andrykonchin andrykonchin mentioned this pull request Dec 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrykonchin @ckhsponge