Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loop syntax bug fix for Omega IOTest #50

Merged

Conversation

philipwjones
Copy link

@philipwjones philipwjones commented Jan 24, 2024

Includes:

  • fix for incorrect loop syntax in all test loops in IOTest.cpp
  • fix for incorrect dimension lengths uncovered by above
  • change in test array sizes to better represent production model
  • fix for incorrect initialization in Decomp (harmless so far)
  • adds needed memory cleanup at end of test

Unit tests pass on Chrysalis/Intel, will report additional tests below

Checklist

  • Documentation: No changes
  • Testing
    • A comment in the PR documents testing used to verify the changes including any tests that are added/modified/impacted.
    • Unit tests have passed. Please provide a relevant CDash build entry for verification.

Fixes #49

  Includes:
  - fix for incorrect loop syntax in all test loops
  - fix for incorrect dimension lengths uncovered by above
  - change in test array sizes to better represent production model
  - fix for incorrect initialization in Decomp (harmless so far)
@philipwjones
Copy link
Author

Also passes unit test on Frontier crayclang once I remembered to execute from a scratch filesystem.

@mark-petersen mark-petersen self-requested a review January 25, 2024 16:12
Copy link

@mark-petersen mark-petersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This now passes the IO_TEST on both chrysalis and perlmutter, per the instructions here: #42 (comment). Thanks!

Copy link
Member

@mwarusz mwarusz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Approving based on visual inspection and testing on my own machine.

Copy link

@brian-oneill brian-oneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm IOTest passes now. Ran successfully on Frontier and Chrysalis.

@philipwjones philipwjones merged commit e951a9b into E3SM-Project:develop Jan 25, 2024
2 checks passed
@philipwjones philipwjones deleted the omega/iotest-loopfix branch March 18, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong loop syntax in IO tests
4 participants