WW3-MPAS-SI Coupling for E3SMv3 #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
December 21, 2023 15:58
…ring. Set as default in switch file E3SMv3
|
@sbrus89 - your review is requested. |
dabail10
reviewed
Jul 26, 2024
model/ftn/w3fld1md.ftn
Outdated
| DO T=1,NTH | ||
| INSPC(K,T)=BT(K)*INSPC(K,T)/TPI/(WN2(K)**3.0)/AVG | ||
| ENDDO | ||
| IF (AVG .GT. 0.0) THEN |
There was a problem hiding this comment.
There is a slightly different coding of this fix in the WW3 main.
There was a problem hiding this comment.
thanks for noticing @dabail10 - I will double check
|
Re-opening PR with updated WW3 code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
This PR implements several changes to the WW3 model for wave-sea ice coupling in E3SM.
Description
This PR makes several changes to the WW3 code base. The major changes include:
adding a new 'switch' file with the sea ice settings for wave-sea ice coupling in E3SM (IC4, IS0).
implementing the new wave attenuation scheme for waves in sea ice based on Meylan et al. (https://doi.org/10.1016/j.ocemod.2021.101779). In the E3SM branch of WW3: this setting is "IC4 Method 8".
This attenuation scheme takes into consideration damping in sea ice due to scattering, so scattering term must be turned off (IS0 used in new switch file) to avoid 'double counting' effects due to scattering in sea ice.
Lastly, this PR includes an update to the numerics calculation for IC4 based on calculations from Cecilia Bitz. It is numerically more accurate to determine the attenuation of waves in sea ice THEN determine the breaking of ice due to the damped waves. This is implemented through a new logical namelist parameter under the SIC4 namelist group. The new parameter is called "IC4_NUMERICS" and if this is set to "TRUE" the new numerics fix will be implemented (note this is only implemented for IC4)
Note: This numerics fix is expected to be merged into the official NOAA/EMC branch of WW3 and is being discussed here: Improve numerical solution for waves in sea ice NOAA-EMC/WW3#738