Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create one logger object per instantiated Run() object and fix logger not including full traceback #924

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tomvothecoder
Copy link
Collaborator

@tomvothecoder tomvothecoder commented Jan 22, 2025

Description

What we need

  • One logger module saved to file per simulation
  • All logger outputs for one simulation saved to a file (via append)
    • Works with serial -- works
    • Works with multiprocess -- blank file
  • Save log directly to prov instead of waiting for run to end (makes debugging harder)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

If applicable:

  • New and existing unit tests pass with my changes (locally and CI/CD build)
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have noted that this is a breaking change for a major release (fix or feature that would cause existing functionality to not work as expected)

@tomvothecoder tomvothecoder self-assigned this Jan 22, 2025
@tomvothecoder tomvothecoder added the bug Bug fix (will increment patch version) label Jan 22, 2025
@chengzhuzhang
Copy link
Contributor

@tomvothecoder Another thing that bothers me a little, is that the e3sm_diags_run.log file was created in the directory where the run script is located, I'm wondering if it makes more sense to have it initiate under /prov, right away?

@tomvothecoder tomvothecoder marked this pull request as draft January 22, 2025 23:24
@tomvothecoder tomvothecoder changed the title Create one logger object per instantiated Run() object Create one logger object per instantiated Run() object and fix logger not including full traceback Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug fix (will increment patch version)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: prov log doesn't include complete traceback [Bug]: e3sm_diags_run.log was not properly generated
2 participants