Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spio_hash.h not installed together with pio.h #556

Closed
dqwu opened this issue Jan 12, 2024 · 1 comment · Fixed by #558
Closed

spio_hash.h not installed together with pio.h #556

dqwu opened this issue Jan 12, 2024 · 1 comment · Fixed by #558
Assignees

Comments

@dqwu
Copy link
Contributor

dqwu commented Jan 12, 2024

In pio.h, spio_hash.h is explicitly included:
#include "spio_hash.h" /* Hash table implementation for ADIOS read */

However, this file is not installed together with pio.h under the include directory.

Steps to reproduce this issue on ANL Ubuntu 20 workstations:

module load cmake/3.20.5-zyz2eld
module load gcc/11.1.0-qsjmpcg
export PATH=/nfs/gce/projects/climate/software/linux-ubuntu20.04-x86_64/mpich/4.0/gcc-11.1.0/bin:$PATH

git clone https://github.com/E3SM-Project/scorpio.git
cd scorpio

mkdir build
cd build

ADIOS2_DIR=/nfs/gce/projects/climate/software/linux-ubuntu20.04-x86_64/adios2/2.9.1/mpich-4.0/gcc-11.1.0 \
CC=mpicc CXX=mpicxx FC=mpifort cmake -Wno-dev \
-DCMAKE_INSTALL_PREFIX=$HOME/spio \
-DWITH_ADIOS2=ON \
-DWITH_NETCDF=OFF \
-DPnetCDF_PATH=/nfs/gce/projects/climate/software/linux-ubuntu20.04-x86_64/pnetcdf/1.12.2/mpich-4.0/gcc-11.1.0 \
-DPIO_USE_MALLOC=ON \
..

make

make install

ls $HOME/spio/include/*.h

This issue was initially mentioned in #554 by a user of ESMF and SCORPIO:

I tried to compile scorpio with esmf. I included scorpio include path and adios2 include path. But I still got this error:
In file included from /glade/.../esmf/src/Infrastructure/IO/src/ESMCI_IO_Handler.C:36:
In file included from /glade/.../esmf/src/Infrastructure/IO/src/../include/ESMCI_PIO_Handler.h:45:
/glade/.../scorpio/install/include/pio.h:71:10: fatal error: In file included from /glade/.../esmf/src/Infrastructure/IO/src/ESMCI_PIO_Handler.C:'spio_hash.h' file not found27:

@jayeshkrishna
Copy link
Contributor

This issue can be reproduced by building a SCORPIO application with _ADIOS2 preproc defn,

${CXX} -D_ADIOS2 ... spio_hello.cpp

jayeshkrishna added a commit that referenced this issue Jan 27, 2024
…op (PR #558)

Remove spio_hash.h from the user header file, pio.h

Fixes #556

* jayeshkrishna/fix_missing_spio_hash_install:
  Rm spio_hash.h from pio.h
jayeshkrishna added a commit that referenced this issue Jan 30, 2024
…pio_hash_install

Remove spio_hash.h from the user header file, pio.h

Fixes #556
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants