-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change workflows to mamba, take 2 #438
Change workflows to mamba, take 2 #438
Conversation
* Change workflow to mamba
* Fix GitHub Actions * Revert sphinx-multiversion handling
@@ -26,10 +26,9 @@ dependencies: | |||
# If versions are updated, also update in `.github/workflows/build_workflow.yml` | |||
# ================= | |||
- sphinx=5.2.3 | |||
- sphinx-multiversion=0.2.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this matters but using single rather than double =
here to match other dependencies.
# IMPORTANT: This needs to be set for caching to work properly! | ||
use-only-tar-bz2: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is necessary any longer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And I think it causes problems because most newer releases are as .conda
files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may explain why sphinx-multiversion
couldn't be installed.
# Using pip for Sphinx dependencies because it takes too long to reproduce a conda environment (~10 secs vs. 3-4 mins) | ||
- name: Install Dependencies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be much better with mamba
instead of conda
.
@forsyth2 and @tomvothecoder, I think the problem with #429 and #434 were that you did not actually switch to creating a mambaforge environment for building the docs. The environment was still being created with |
Unfortunately, we do not have a good way of testing these workflows until we merge this branch and make an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @xylar! This looks good from what I can tell. Should I merge it?
@forsyth2, I think so but I really can't be sure until we actually try a merge and see how it goes. |
@forsyth2, it seems like things worked fine so let's proceed with zstash. |
This merge attempts to move all workflows (including building the documentation) to
mamba
instead ofpip
.