Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove keep from config #177

Merged
merged 1 commit into from
Jan 12, 2022
Merged

Remove keep from config #177

merged 1 commit into from
Jan 12, 2022

Conversation

forsyth2
Copy link
Collaborator

Remove keep from the config. Resolves #63

@forsyth2 forsyth2 self-assigned this Jan 10, 2022
@forsyth2 forsyth2 force-pushed the remove-keep branch 2 times, most recently from bddca74 to 12b2f83 Compare January 11, 2022 02:03
@forsyth2 forsyth2 marked this pull request as ready for review January 11, 2022 02:04
@forsyth2
Copy link
Collaborator Author

@golaz This is ready for review. We're only trying to remove keep from the config, correct? That is, we're keeping the --keep option available?

The unit tests still pass (aside from the unrelated failure caused by #176).

@forsyth2 forsyth2 requested a review from golaz January 11, 2022 18:39
golaz
golaz approved these changes Jan 12, 2022
View reviewed changes
Copy link
Collaborator

@golaz golaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the change. Looks like it actually simplifies the code slightly.

@forsyth2 forsyth2 merged commit fa4fcbd into E3SM-Project:master Jan 12, 2022
@forsyth2 forsyth2 deleted the remove-keep branch January 12, 2022 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@golaz golaz golaz approved these changes

Assignees

@forsyth2 forsyth2

Labels
priority: low Low priority task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove keep from config
2 participants
@forsyth2 @golaz