Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip]use Eccube-Upgrade-Fixer #97

Closed
wants to merge 16 commits into from
Closed

[wip]use Eccube-Upgrade-Fixer #97

wants to merge 16 commits into from

Conversation

nobuhiko
Copy link
Collaborator

No description provided.

nobuhiko added 4 commits June 17, 2022 10:02
…\Admin\ConfigControllerTest::setUp() must be compatible with Eccube\Tests\Web\Admin\AbstractAdminWebTestCase::setUp(): void in /home/runner/work/data-migration-plugin/data-migration-plugin/app/Plugin/DataMigration4/Tests/Web/Admin/ConfigControllerTest.php on line 18
@chihiro-adachi
Copy link
Contributor

@nobuhiko
github actionsの修正、こちらのPRでも実施してますので参考にしていただければと。
EC-CUBE/ProductReview-plugin#74

@nobuhiko
Copy link
Collaborator Author

@chihiro-adachi
ありがとうございます。4.2ってもしかしてテーブル名も結構変わってますか?

nobuhiko added 3 commits June 17, 2022 11:20
?
Can't create database 'eccube_db'; database exists
@chihiro-adachi
Copy link
Contributor

@nobuhiko
既存のテーブルやカラムに変更はないです。

特商法関連で一つテーブルが追加されます。
EC-CUBE/ec-cube#5304 (comment)

nobuhiko added 3 commits June 17, 2022 11:42
…ndex(): Argument #2 ($em) must be of type Doctrine\DBAL\Driver\Connection, Doctrine\DBAL\Connection given
@nobuhiko
Copy link
Collaborator Author

@chihiro-adachi
ありがとうございます。
おそらく、database_charset がないとうまく動かなかったのかな・・・?という感じです。
いずれにしてもプラグイン動かないっすね

@nobuhiko
Copy link
Collaborator Author

テストが通らないのは本体の問題な感じがするので、とりあえず保留

@nobuhiko nobuhiko closed this Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants