Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnitTestとE2Eのカバレッジを分離 #5113

Merged
merged 1 commit into from
Sep 30, 2021

Conversation

kiy0taka
Copy link
Contributor

@kiy0taka kiy0taka commented Aug 18, 2021

概要(Overview・Refs Issue)

UnitTestとE2Eとを合わせてカバレッジを出していたので、それぞれを分けて計測するようにしました。

image

方針(Policy)

実装に関する補足(Appendix)

テスト(Test)

相談(Discussion)

マイナーバージョン互換性保持のための制限事項チェックリスト

  • 既存機能の仕様変更
  • フックポイントの呼び出しタイミングの変更
  • フックポイントのパラメータの削除・データ型の変更
  • twigファイルに渡しているパラメータの削除・データ型の変更
  • Serviceクラスの公開関数の、引数の削除・データ型の変更
  • 入出力ファイル(CSVなど)のフォーマット変更

レビュワー確認項目

  • 動作確認
  • コードレビュー
  • E2E/Unit テスト確認(テストの追加・変更が必要かどうか)
  • 互換性が保持されているか
  • セキュリティ上の問題がないか

@codecov-commenter
Copy link

Codecov Report

Merging #5113 (dbdee3f) into 4.1 (e4e7513) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                4.1    #5113      +/-   ##
============================================
- Coverage     68.17%   68.17%   -0.01%     
- Complexity        0     6039    +6039     
============================================
  Files           457      457              
  Lines         24980    24980              
============================================
- Hits          17031    17029       -2     
- Misses         7949     7951       +2     
Flag Coverage Δ
E2E 55.17% <ø> (?)
Unit 75.79% <ø> (?)
tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...orage/Handler/SameSiteNoneCompatSessionHandler.php 88.05% <0.00%> (-2.99%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4e7513...dbdee3f. Read the comment docs.

@okazy okazy added this to the 4.1 milestone Aug 19, 2021
@okazy okazy added the improvement 機能改善 label Aug 19, 2021
@chihiro-adachi chihiro-adachi modified the milestones: 4.1, 4.1.x Sep 3, 2021
@chihiro-adachi chihiro-adachi modified the milestones: 4.1.x, 4.1.1 Sep 30, 2021
@chihiro-adachi chihiro-adachi merged commit 52651e8 into EC-CUBE:4.1 Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement 機能改善
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants