Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEAR::SOAP は PHP8 で動作しないため削除 #1092

Merged
merged 2 commits into from
Dec 24, 2024

Conversation

nanasess
Copy link
Contributor

refs #355

  • 元々 EC-CUBE本体では使用しておらず、一部の決済モジュール向けにバンドルしていたが、PHP8 の環境では動作しないため削除
  • SOAP が必要な場合は SOAP extension を使用する

- PHP8 では動作しないため削除
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.94%. Comparing base (980ce37) to head (0b479a7).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1092   +/-   ##
=======================================
  Coverage   50.94%   50.94%           
=======================================
  Files          80       80           
  Lines       10256    10256           
=======================================
  Hits         5225     5225           
  Misses       5031     5031           
Flag Coverage Δ
tests 50.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nanasess nanasess added this to the 2.18(仮) milestone Dec 20, 2024
@nanasess nanasess enabled auto-merge December 24, 2024 05:14
@nanasess nanasess merged commit a248cbd into EC-CUBE:master Dec 24, 2024
108 checks passed
@nanasess nanasess deleted the remove-pear-soap branch December 24, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants