Full update of regular (non-EB) boundary buffer #4748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RemiLehe
force-pushed
the
regular_boundaries_whole
branch
from
b6c92f9 to
4828538
Compare
RemiLehe
force-pushed
the
regular_boundaries_whole
branch
from
4828538 to
9903703
Compare
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim of this PR is to have the same attributes in the non-EB boundary buffer as in the EB boundary buffer.
-the exact position when it hits: corrected
-the step
-the exact time when it hits: corrected (was set on 0 by default)
-the normal components: #4742
TO DO: adding a test (at least in RZ), review the efficiency of the code (especially for RZ coordinates)