-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Take Version and PicsarVersion out of the WarpX class #4967
base: development
Are you sure you want to change the base?
Take Version and PicsarVersion out of the WarpX class #4967
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok :)
…_and_PicsarVersion_out_of_the_WarpX_class
Restarting CI |
…_and_PicsarVersion_out_of_the_WarpX_class
Restarting CI |
@lucafedeli88 I think the GNU makefile needs a touch-up for this to pass. |
…_and_PicsarVersion_out_of_the_WarpX_class
@ax3l , I had a look at the GNU makefile. It seems to me that when we compile with the GNU makefile there is an AMReX tool that takes care of generating The solution I chose is to leave |
This PR takes Version and PicsarVersion out of the WarpX class and puts them in a
warpx
namespace.The goal is twofold: 1) reducing the complexity of the WarpX class 2) possibly avoid in the future the inclusion of the huge WarpX class where we only need the version of WarpX and Picsar.
With the occasion, the two functions are made
noexcept
and[[nodiscard]]
.