Flux injection from EB: Pick a random point instead of the centroid #5493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WeiqunZhang
force-pushed
the
eb_sampling
branch
from
40e38e7 to
4116f29
Compare
WeiqunZhang
force-pushed
the
eb_sampling
branch
from
4116f29 to
be9b7e2
Compare
WeiqunZhang
force-pushed
the
eb_sampling
branch
from
be9b7e2 to
9370e75
Compare
|
@EZoni If you submit a weekly update PR before this PR is merged, note that you need to update the dependency scripts to install cusparse and rocsparse that are now required by amrex. |
|
The segfault is fixed now. It was because the tests did not have EB, but it was compiled with EB support. |
WeiqunZhang
force-pushed
the
eb_sampling
branch
from
9012038 to
59ef806
Compare
|
Needs AMReX-Codes/amrex#4277 |
WeiqunZhang
force-pushed
the
eb_sampling
branch
2 times, most recently
from
7e5af50 to
93cd459
Compare
Also use higher resolution for the flux injection from eb test, and update benchmarks
WeiqunZhang
force-pushed
the
eb_sampling
branch
from
4005eaa to
60608bd
Compare
RemiLehe
reviewed
Jan 30, 2025
RemiLehe
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.