Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WarpX class: make zmax_plasma_to_compute_max_step a private member variable and remove do_compute_max_step_from_zmax #5605

Conversation

lucafedeli88
Copy link
Member

This PR combines the following static variables of the WarpX class:

static amrex::Real zmax_plasma_to_compute_max_step;
static bool do_compute_max_step_from_zmax;

into a single private member variable:

std::optional<amrex::Real> m_zmax_plasma_to_compute_max_step = std::nullopt;

This is a small step towards reducing reliance on static class variables.

@lucafedeli88 lucafedeli88 added the cleaning Clean code, improve readability label Jan 24, 2025
@ax3l ax3l self-requested a review January 24, 2025 22:47
@ax3l ax3l added the component: boosted frame boosted frame components & logic label Jan 24, 2025
Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ax3l ax3l merged commit 27aaa0b into ECP-WarpX:development Jan 24, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleaning Clean code, improve readability component: boosted frame boosted frame components & logic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants