Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup: CI #110

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Fixup: CI #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9b7c29
fixup: unused return warnings
streeve Jan 16, 2024
c0ba9eb
fixup: weekly ci
streeve Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/Weekly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,13 +52,13 @@ jobs:
cmake -B build \
-D CMAKE_BUILD_TYPE=${{ matrix.cmake_build_type }} \
-D CMAKE_CXX_FLAGS="-Wall -Wextra -pedantic -Werror" \
-D CMAKE_INSTALL_PREFIX=$HOME/CabanaPD \
-D CMAKE_INSTALL_PREFIX=$HOME/CabanaMD \
-D CMAKE_PREFIX_PATH="$HOME/Cabana" \
-D MPIEXEC_MAX_NUMPROCS=2 \
-D MPIEXEC_PREFLAGS="--oversubscribe" \
-D CabanaPD_ENABLE_TESTING=ON
-D CabanaMD_ENABLE_TESTING=ON
cmake --build build --parallel 2
cmake --install build
- name: Test CabanaPD
- name: Test CabanaMD
run: |
CTEST_OUTPUT_ON_FAILURE=1 cmake --build build --target test
14 changes: 7 additions & 7 deletions src/cabanamd_impl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,7 @@ void CbnMD<t_System, t_Neighbor>::check_correctness( int step )
log_err( err, "Cannot open input file: ", filename );
}

fread( &ntmp, sizeof( T_INT ), 1, fpref );
(void)fread( &ntmp, sizeof( T_INT ), 1, fpref );
if ( ntmp != n )
{
log_err( err, "Mismatch in current and reference atom counts" );
Expand All @@ -511,12 +511,12 @@ void CbnMD<t_System, t_Neighbor>::check_correctness( int step )
Kokkos::View<T_F_FLOAT **, Kokkos::LayoutRight> fref( "Correctness::f", 3,
n );

fread( idref.data(), sizeof( T_INT ), n, fpref );
fread( typeref.data(), sizeof( T_INT ), n, fpref );
fread( qref.data(), sizeof( T_FLOAT ), n, fpref );
fread( xref.data(), sizeof( T_X_FLOAT ), 3 * n, fpref );
fread( vref.data(), sizeof( T_V_FLOAT ), 3 * n, fpref );
fread( fref.data(), sizeof( T_F_FLOAT ), 3 * n, fpref );
(void)fread( idref.data(), sizeof( T_INT ), n, fpref );
(void)fread( typeref.data(), sizeof( T_INT ), n, fpref );
(void)fread( qref.data(), sizeof( T_FLOAT ), n, fpref );
(void)fread( xref.data(), sizeof( T_X_FLOAT ), 3 * n, fpref );
(void)fread( vref.data(), sizeof( T_V_FLOAT ), 3 * n, fpref );
(void)fread( fref.data(), sizeof( T_F_FLOAT ), 3 * n, fpref );

T_FLOAT sumdelrsq = 0.0;
T_FLOAT sumdelvsq = 0.0;
Expand Down