fix docker build #357
fix docker build #357
Conversation
- push to dockerhub if setup - push to github - build arm (mac) container as well as x86
|
working on adding the intel compiler |
|
Please squash the PR when ready, to many build errors and tries. |
|
Will update this to also push the intermediate image with the build results to make it easier for others to build ED. |
|
I have to figure out we this can be fixed.Right now it has 22GB of disk storage, but when pulling the intel image we are left with 900Mb, not enough to build the docker image. |
There was a problem hiding this comment.
Thanks for the updates, @robkooper! I think these look great. I just had one minor question about versions in the ci.yml file that may or may not be relevant.
| MASTER_REPO: EDModel/ED2 | ||
| DOCKERHUB_ORG: pecan | ||
| MAIN_REPO: EDmodel/ED2 | ||
| DOCKERHUB_ORG: edmodel |
There was a problem hiding this comment.
Nice catch, though we should probably acknowledge that this code is based on PEcAn somewhere.
| @@ -53,3 +54,23 @@ If you plan to develop the code, please refer to the Wiki entries on <a href="ht | |||
|
|
|||
| We strongly encourage that code developments are properly documented. Please refer to the <a href="https://github.com/EDmodel/ED2/wiki/ED2-Documentation-with-Doxygen">Doxygen</a> instructions, and especially the <a href="https://github.com/EDmodel/ED2/wiki/ED2-Documentation-with-Doxygen#doxygit"> Doxygen and Git commits</a> section, so additional documentation can be automatically generated from the source code comments. | |||
|
|
|||
| ## <a name="docker"> Using Docker</a> | |||
There was a problem hiding this comment.
Thanks for adding this! By the way, we can also include additional documentation (if needed) in the Wiki.
fixes #355
Types of changes
Checklist:
Testing :