add workflow to update overview of available software #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boegel
commented
Jun 5, 2024
| root_dir = next( | ||
| p for p in current_dir.parents if p.parts[-1] == project_name | ||
| ) | ||
| root_dir = os.path.dirname(os.path.dirname(os.path.dirname(os.path.abspath(__file__)))) |
There was a problem hiding this comment.
I changed this because the available_software.py script was failing in a checkout my fork, because the top-level directory there was EESSI-docs rather than docs.
I don't see the need to use pathlib here, it makes the code a whole lot more messy and hard to understand, imho
trz42
requested changes
Jun 5, 2024
…of available software
Good point, fixed in 9ce8952 |
|
Almost
|
|
Ah dispatch workflow, but still problems: https://github.com/EESSI/docs/actions/runs/9391493091/job/25863767460 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, I've only listed
workflow_dispatchas a trigger, which essentially means that triggering the creation of a PR will only happen when someone runs the workflow via https://github.com/EESSI/docs/blob/main/.github/workflows/update_available_software.yml .I prefer taking that approach initially, before we enable daily (or whatever) runs of this workflow to automatically get a PR opened when the overview of available software needs to be updated...
The token (available as GitHub Action environment secret in this repo as
EESSIBOT_GITHUB_TOKEN) is currently valid until 4 Aug'24, we'll need to make sure it gets replaced regularly (out of abundance of care).Example of a pull request that is produced by this workflow (which was tweaked to use the
boegelbotaccount and target my fork @boegel/EESSI-docs: boegel#2