.ignoreFirstSeparator and renderer customizations ignored on reloadData()

[fahlout]

After calling reloadData() the initial customizations I have made like .ignoreFirstSeparator seem to be ignored as it shows the first separator again after reload. Same happens when adding customization to the renderer.

[EMart86]

Hi @fahlout, sorry that it took that long! I've been working on that issue and fixed it. If you've any recommendations, i'll be glad to work on that. Best!

[fahlout]

@EMart86 I just updated your library through cocoa pods for my project and am unfortunately still experiencing the same issue. Maybe I'm setting it up wrong. Could you send me some code as to how to set it up so I can compare with my code?

In my code this is how I'm setting it up:

func setupTickerView(_ tickerView: SwiftTickerView, dataSet: [String]) {
        let tickerProvider = TickerProvider()
        tickerProvider.content = dataSet
        tickerView.contentProvider = tickerProvider
        tickerView.viewProvider = self
        tickerView.separator = "..."
        tickerView.add(decorator: .ignoreFirstSeparator)
        tickerView.distanceBetweenNodes = 10
        tickerView.render = Renderer.rightToLeft
        tickerView.registerNodeView(UILabel.self, for: tickerLabelIdentifier)
        tickerView.tickerDelegate = self
    }

[EMart86]

Your code runs perfectly fine in the example project i've provided with this pod. Are you supporting iOS 9 within your app? I've had struggles with ios 9 thats why i dropped it, but with the latest version 1.4.3 i'm supporting it again. Pls let me know if it helped. Best

[fahlout]

I think I got it figured out now. I'm only supporting 10.2 or above so that wasn't the issue, but rather the way I coded the reloading part was not correct. The setup code above worked, but once I reloaded things were not working correctly.

The modifications I had to make were to add tickerView.reloadData() to the end of my setup function and when I want to reload I had to call the setup again with my new data set and set the index of my content provider back to 0 and call reloadData() again. I'm not sure why I have to setup the entire ticker view again every time I want to reload data, but that was the only way to get it to work for me. I was just setting the new content to the provider before and calling reloadData(). Here is my code for the reloading part:

func reloadTickerView(with alertDescriptions: [String]) {
    setupTickerView(tickerView, dataSet: alertDescriptions)
    guard let contentProvider = (tickerView.contentProvider as? TickerProvider) else { return }
    contentProvider.updateContent()
    tickerView.reloadData()
}

class TickerProvider: SwiftTickerProviderProtocol {
    
    ...
    
    func updateContent() {
        index = 0
    }
}

[EMart86]

Hi, you actually don't need to resetup the whole ticker view. I've looked up in my sample project at https://github.com/EMart86/SwiftTickerView/blob/master/Example/SwiftTickerView/ViewController.swift at line number 62.

@IBAction func updateContentAndReload(_ sender: Any) { tickerContentProvider.updateContent() tickerView.reloadData() }

This is all i do, when reloading the content

[ChetanPote93]

hello I am facing issue is that when I passing array first time there is no gap and after navigating from one screen to another and came back again.

[EMart86]

@ChetanPote93 Could you please provide my your setup code?
Especially with the tickerView.distanceBetweenNodes part.
Or maybe use tickerView.reloadData()