Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix result caching on refresh and add scroll to Icon in shared links #22

Merged
merged 3 commits into from
Jan 29, 2022
Merged

Fix result caching on refresh and add scroll to Icon in shared links #22

merged 3 commits into from
Jan 29, 2022

Conversation

ayushsatyam146
Copy link
Contributor

Fixed issues mentioned in Issue #16. On refreshing the page selected Icon doesn't get lost and the selected Icon persists after Page refresh. Whenever a user opens a shared link of an icon the page auto scrolls to the shared icon and highlights the shared Icon as a selection.
I have tested all the scenarios by picking Icons from the top, middle and bottom and also from different categories.
To better illustrate the behavior a video has been attached testing all the scenarios.

EOS-Issue-16.mp4

@vinayaksh42
Copy link
Member

vinayaksh42 commented Jan 28, 2022

@ayushsatyam146 Great work, the scrolling to the selected icon upon sharing or re-loading the page works perfectly, but this seems to be breaking the search by tag and share by tag functionality (explained in video):

De4IDSlpx4.mp4

@ayushsatyam146
Copy link
Contributor Author

@ayushsatyam146 Great work, the scrolling to the selected icon upon sharing or re-loading the page works perfectly, but this seems to be breaking the search by tag and share by tag functionality (explained in video):

De4IDSlpx4.mp4

@vinayaksh42 Thanks for mentioning the issue, added a new commit fixing this.

@vinayaksh42
Copy link
Member

LGTM!
@ayushsatyam146 share by tag seems to be working now

@vinayaksh42
Copy link
Member

@ayushsatyam146 The Test pull request workflow keeps on failing for all the new pull requests. Would you like to have a look at it?

@vinayaksh42 vinayaksh42 merged commit f7f693e into EOS-uiux-Solutions:master Jan 29, 2022
@vinayaksh42
Copy link
Member

@ayushsatyam146 The scrolling feature seems not to be working in production, Kindly check with it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants