Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

P2P sync failing #421

Closed
heifner opened this issue Sep 13, 2017 · 6 comments · Fixed by #543
Closed

P2P sync failing #421

heifner opened this issue Sep 13, 2017 · 6 comments · Fixed by #543
Assignees
Milestone

Comments

@heifner
Copy link
Contributor

heifner commented Sep 13, 2017

This issue is related to #291 stability.

Current sync of producer nodes is not working. Steps to reproduce:

  • programs/launcher/launcher -p5 -s mesh --skip-signature
    • -s star, -s ring also exhibit same issue
  • programs/eosc/eosc --port 8888 get block 1
  • programs/eosc/eosc --port 8889 get block 1
  • programs/eosc/eosc --port 8890 get block 1
  • programs/eosc/eosc --port 8891 get block 1
  • programs/eosc/eosc --port 8892 get block 1
    • The blocks returned do not agree.
    • Also the following is in tn_data_*/stderr.txt
426004ms thread-0   net_plugin.cpp:820            handle_message       ] unable to accept block #3 syncing
426004ms thread-0   fork_database.cpp:65          push_block           ] Pushing block to fork database that failed to link: 00000003dcb43dac9f0083ea66e8f62ca0eaf0b6141894412ee3557c4b7a6a18, 3
426004ms thread-0   fork_database.cpp:66          push_block           ] Head: 2, 000000020f5b636cd1777ce3453373501ce6bbccd158725470d91ca855821dde
  • Large amounts of memory were consumed by the eosd
@heifner heifner self-assigned this Sep 13, 2017
@heifner
Copy link
Contributor Author

heifner commented Sep 14, 2017

Created a simple test and handed it over to Phil who is actively working this issue with #406. It is much more stable in branch p2p-txn-handling-393, but still can be made to fail via dropped connections.

@pmesnier pmesnier self-assigned this Sep 14, 2017
@pmesnier
Copy link
Contributor

I've created a new branch off of "staging" to carry on my work sorting out the p2p networking functionality. This issue relates back to #291 and the working branch is p2p-sync-slow-peers.

@pmesnier
Copy link
Contributor

Since I'm not actually working this issue directly, I'm removing the in progress label for now

@pmesnier
Copy link
Contributor

I'm pretty sure this is failing simply because the last bit of sync code isn't in place yet. This is the part involving fetching the blocks post irreversible.

pmesnier added a commit that referenced this issue Oct 5, 2017
…ocaition for test verifying this solution, suppressed debug output and added a config option to net plugin
pmesnier added a commit that referenced this issue Oct 5, 2017
…ocaition for test verifying this solution, suppressed debug output and added a config option to net plugin
@pmesnier
Copy link
Contributor

pmesnier commented Oct 5, 2017

Solution added with PR #543

@pmesnier
Copy link
Contributor

pmesnier commented Oct 5, 2017

PR #543 addresses this issue

@pmesnier pmesnier closed this as completed Oct 5, 2017
@thomasbcox thomasbcox added this to the EOS Dawn 1.1 milestone Nov 9, 2017
nksanthosh added a commit that referenced this issue Aug 3, 2020
This CLI11 update from v1.9.0 to v1.9.1 provides the following improvements: 
- Support relative inclusion [#475](CLIUtils/CLI11#475)
- Fix cases where spaces in paths could break CMake support [#471](CLIUtils/CLI11#471)
- Fix an issue with string conversion [#421](CLIUtils/CLI11#421)
- Cross-compiling improvement for Conan.io [#430](CLIUtils/CLI11#430)
- Fix option group default propagation [#450](CLIUtils/CLI11#450)
- Fix for C++20 [#459](CLIUtils/CLI11#459)
- Support compiling with RTTI off [#461](CLIUtils/CLI11#461)
dimas1185 pushed a commit that referenced this issue Aug 4, 2020
This CLI11 update from v1.9.0 to v1.9.1 provides the following improvements: 
- Support relative inclusion [#475](CLIUtils/CLI11#475)
- Fix cases where spaces in paths could break CMake support [#471](CLIUtils/CLI11#471)
- Fix an issue with string conversion [#421](CLIUtils/CLI11#421)
- Cross-compiling improvement for Conan.io [#430](CLIUtils/CLI11#430)
- Fix option group default propagation [#450](CLIUtils/CLI11#450)
- Fix for C++20 [#459](CLIUtils/CLI11#459)
- Support compiling with RTTI off [#461](CLIUtils/CLI11#461)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants