This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Fix incorrect prune state of a signed_block issue #10344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickjjzhao
changed the title
|
Don't forget to back-port to 2.1 |
heifner
reviewed
May 11, 2021
| @@ -186,7 +186,7 @@ | |||
| Utils.Print("Post light validation waiting info for each node:\nproducer: {}\nfull: {},\nlight: {}".format(json.dumps(pvnPostInfo, indent=1), json.dumps(fvnPostInfo, indent=1), json.dumps(lvnPostInfo, indent=1))) | |||
| Utils.Print("Post full validation waiting info for each node:\nproducer: {}\nfull: {},\nlight: {}".format(json.dumps(pvnPost2Info, indent=1), json.dumps(fvnPost2Info, indent=1), json.dumps(lvnPost2Info, indent=1))) | |||
|
|
|||
| assert not headAdvanced, "the full validation node is still syncing" | |||
| assert (not headAdvanced) or (fvnPost2Info["head_block_num"] < cfTrxBlockNum), "the full validation node is still syncing" | |||
There was a problem hiding this comment.
Why were these two additions needed? waitForHeadToAdvance() should be enough, right?
There was a problem hiding this comment.
It happened locally for full validation node that headAdvanced was true but the node hadn't synced up to the pruned block yet. Similar to the light validation node, its headAdvanced was false but the node had already passed the pruned block. I think we should treat these situations as success not failure so I added two extra conditions. I might be wrong.
heifner
approved these changes
May 11, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
The variable
prune_statein asigned_blockshould be updated after some trxs in the block get pruned that happens inprune_trxs(). Otherwise in some situationto_signed_block_v0()will try to convert asigned_blockwith pruned trxs to asigned_block_v0, which is not supposed to, due to incorrect state of the variable.Change Type
Select ONE:
Testing Changes
Select ANY that apply:
Consensus Changes
API Changes
Documentation Additions