This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Eosc overhaul #221
Merged
Eosc overhaul #221
+19,985
−1,515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are there any docs to update other than https://eosio.github.io/eos/group__eosc.html? |
|
This pull request needs to be rebased on current master with fixed submodule. |
nathanielhourt
force-pushed
the
eosc-overhaul-203
branch
from
a904049 to
e219817
Compare
heifner
reviewed
Aug 26, 2017
| @@ -21,6 +22,8 @@ | |||
|
|
|||
| #include <fc/io/fstream.hpp> | |||
|
|
|||
| #include "CLI11.hpp" | |||
There was a problem hiding this comment.
Comment with verison of CLI11 used might be helpful, I assume version 1.1.
There was a problem hiding this comment.
At this point we're using the HEAD version, as 1.1 contained a bug which I reported and he fixed, slated for release in version 1.2. I've included the header in our source distribution so there's no worries about having to go find the right version.
Add CLI11 library and begin porting commands from the old mechanism to the new one.
Update `eosc push-trx` to `eosc push transaction`
Add Contract command to replace old setcode Rename Exec command to Push Fix some API naming compatibility with current eosd
Remove all the cruft and old code TODO: Fix massive use-after-free bugs in stack-allocated CLI parameter storage
- Put all CLI variables in full scope of main() so they live long enough to get used - Update CLI11.hpp to fix a bug that was affecting us: https:// github.com/CLIUtils/CLI11/issues/23
Fix a slippery little bug in the new eosc, which was causing messages' data payloads to be a serialized Bytes object rather than merely the bytes contained by the object. The difference was just one length byte at the beginning of the message data payload, but of course that was enough to break parsing.
nathanielhourt
force-pushed
the
eosc-overhaul-203
branch
from
e219817 to
0b55c25
Compare
programs/eosc/main.cpp was invasively merged ref #203
bytemaster
approved these changes
Aug 29, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion in #203