This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Create validate-reflection-test in Parallel Test Group #7764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
heifner pointed out in issue 7761 that the validation reflection check has been removed from Buildkite, and that this check is currently failing on
develop.I have created a
validate-reflection-testas a part of the parallel test group which calls the validation reflection script the same way it had been called previously. Now this check will be run on Buildkite, the upcoming Travis CI pipeline for the community, and locally. Making it a unit test also reduces the complexity of the pipelines and prevents pipeline changes from disabling it.Tested
Tested working in build 15107, which correctly failed on the unit tests as expected.
See Also
eos:release/1.8.xConsensus Changes
None.
API Changes
None.
Documentation Additions
None.