Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Fix some issues when building EOSIO contracts #968

Merged
merged 4 commits into from
Nov 30, 2020

Conversation

swatanabe-b1
Copy link
Contributor

Change Description

  • Fix dependency file generation (-MD/-MMD) to hold the original source and not the generated temporary file.
  • Make temporary filenames unique to avoid races in parallel builds.

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

Copy link
Contributor

@arhag arhag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two changes I have noticed in the behavior of eosio-cpp with these changes. First, the default name chosen for the .wasm and .abi output files (if not explicitly specified) changes with this patch to something unrelated to the original source file name. Second, even if the compilation is successful it returns a -1 exit code.

That latter regression (at least) seems to be causing all the toolchain tests to fail. I'm not confident if there are other regressions introduced by this patch that may be a source of other problems (whether caught by existing tests or not).

It would be ideal if @larryk85 could also take a look at these changes since he is more familiar with this part of the code.

In addition, @larryk85 you should be aware that this patch fixes bugs (ignoring the regressions/bugs the current version of the patch introduces) with the CDT compiler. So this patch (or rather something like it) should probably be ported not only to the develop branch but also any supported stable release branches.

@swatanabe-b1
Copy link
Contributor Author

Both issues are the same problem.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants