Powerup rename #536
Powerup rename #536
Conversation
| @@ -610,21 +610,21 @@ namespace eosiosystem { | |||
| time_point_sec utilization_timestamp = {}; // When adjusted_utilization was last updated | |||
| }; | |||
|
|
|||
| struct [[eosio::table("rent.state"),eosio::contract("eosio.system")]] rentbw_state { | |||
| static constexpr uint32_t default_rent_days = 30; // 30 day resource rentals | |||
| struct [[eosio::table("powup.state"),eosio::contract("eosio.system")]] powerup_state { | |||
There was a problem hiding this comment.
Renaming tables will break testnets which deployed rentbw
There was a problem hiding this comment.
The new powup.state table will be inconsistent with the other resource-related tables and the weights already assigned to existing accounts which have outstanding rents.
There was a problem hiding this comment.
Is there an option to deploy a modified rentbw-1.9 contract that disables renting and wait for orders to all expire and then deploy the changed contract? It is not ideal but I believe that would work to migrate.
There was a problem hiding this comment.
Never mind that would effectively stop all traffic on the network for 30 days.
There was a problem hiding this comment.
The tests could run a patched version which renames the tables back, but that would create a noticeable difference to tooling which runs on both test nets and non-test nets.
There was a problem hiding this comment.
A modified rentbw-1.9 could disable new rentals and allow rentbwexec to expire existing rentals prematurely. An account with unlimited cpu & net would have to manage this. All normal accounts would be unusable because of eosio.reserv until powerup-1.9 is installed and activated.
There was a problem hiding this comment.
Actually, the modified version needs to clear out the eosio.reserv allocation or powerup-1.9 will malfunction.
|
Some references to the word "rent" remain in the powerup system:
|
…nor typos and comment blocks. Change `process_queue` to a more definitive `process_powerup_queue`.
…seful information to the users.
|
I pulled some sections (and updated them) from the previous RC release notes for some additional information. |
Change Description
This is a renaming of
rentbwtopowerupper the request of the PBE team. These changes are mostly cosmetic renaming of tables and actions. There is also a commit of a new configuration and usage guide.Deployment Changes
This adds an abi that would need to be deployed to eosio.reserv for a no-op action to notify the account of the NET and CPU weight reserved by the account and the associated fee
API Changes
Documentation Additions
There was the addition of a configuration and usage guide docs/04_guides/08_configure-use-powerup-resource-model.md