Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.3 branch: The referenceable dataset getCoverage response does not contain the Content-Length header. #276

Closed
pacesm opened this issue Jul 30, 2014 · 3 comments

Comments

@pacesm
Copy link
Member

pacesm commented Jul 30, 2014

0.3 branch:
The referenceable dataset getCoverage response does not contain the Content-Length header.
This causes a major problem for large file downloads as the client does not have any indication of the payload size. It also seems that (at least some) clients (e.g. ,wget) do not report whether the download finished successfully or because of the connection being interrupted.

0.4 branch: to be verified whether it suffers with the same problem.

@pacesm
Copy link
Member Author

pacesm commented Jul 30, 2014

0.3 branch fixed in 0a0939e
0.4 branch + master to be verified

constantinius added a commit that referenced this issue Aug 4, 2014
…troubles when used as a lazy evaluated list. Somewhat related to #276.

(cherry picked from commit ef63a57)
constantinius added a commit that referenced this issue Aug 4, 2014
…troubles when used as a lazy evaluated list. Somewhat related to #276.
@constantinius
Copy link
Member

This was already implemented in 0.4, I fixed bugs with ef63a57 and 4994aec. The implementation is somewhat quirky with multipart responses, as the size is given for each part and not for the whole response altogether. I'm not sure if this is the intended behaviour by the HTTP standard, I could not find a satisfying answer to this.

@pacesm
Copy link
Member Author

pacesm commented Aug 4, 2014

In the 0.3 fix, I set Content-Length for both the whole muti-part payload and the individual parts. The global one actually matters the most, IMO, as it informs the client about the size of the whole payload. Note that not all clients need to parse the muti-part payload itself (such as wget or ngEO-DM).

constantinius added a commit that referenced this issue Aug 8, 2014
…troubles when used as a lazy evaluated list. Somewhat related to #276.

(cherry picked from commit ef63a57)
@pacesm pacesm closed this as completed May 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants