Fixed helper vector functions / added weak testing #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ease use AzimuthalEquidistantConversion.
|
Hi, thanks a lot, this is helpful. I sent you a contact's request on Linkedin, so I can add you to a developers OST channel, if you are up for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, for context, neither
aoi_to_wktnorlatlon_to_wktwere working in the example notebooks, because of shapely using.wktinstead of.to_wkt()to convert polygons to wkt strings.I also fixed a deprecation warning with pyproj, and added some tests for the vector functions. For this I took the liberty of adding a small geojson to the test files, let me know if I should kill it.
Cheers,
K.