cam6_4_053: Update CARMA external base #1201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: bld/build-namelist modified: bld/namelist_files/namelist_definition.xml
modified: cime_config/testdefs/testlist_cam.xml modified: cime_config/config_pes.xml
cacraigucar
requested changes
Jan 2, 2025
Comment on lines
4482
to
4483
| ZhaoTurco | ||
| Zhao and Turco, JAS, V.26, No.5, 1995. |
There was a problem hiding this comment.
Is there a DOI for this paper, or is it just too old?
There was a problem hiding this comment.
@tilmes and @cbardeen
Is this the Zhao and Turco paper referenced here?
https://doi.org/10.1016/0021-8502(95)00010-A
There was a problem hiding this comment.
Zhao, J. and Turco, R.: Nucleation simulations in the wake of a jet aircraft in stratospheric flight, J. Aerosol Sci., 26, 779–795, https://doi.org/10.1016/0021-8502(95)00010-A, 1995.
src/physics/cam/carma_flags_mod.F90
Outdated
Comment on lines
161
to
163
| call mpi_bcast (carma_flag, 1 ,mpi_logical, masterprocid, mpicom, ierr) | ||
| call mpi_bcast (carma_do_aerosol, 1 ,mpi_logical, masterprocid, mpicom, ierr) | ||
| call mpi_bcast (carma_do_coremasscheck,1 ,mpi_logical, masterprocid, mpicom, ierr) |
There was a problem hiding this comment.
Now that you have error codes, perhaps they should be checked?
src/physics/carma/cam/carma_intr.F90
Outdated
Comment on lines
11
to
17
|
|
||
| use carma_precision_mod | ||
| use carma_enums_mod | ||
| use carma_constants_mod | ||
| use carma_constants_mod, only : GRAV, REARTH, WTMOL_AIR, WTMOL_H2O, R_AIR, CP, RKAPPA | ||
| use carma_types_mod | ||
| use carma_flags_mod | ||
| use carma_model_mod |
There was a problem hiding this comment.
The rest of these should probably have the "only" added to them as well
fvitt
commented
Jan 2, 2025
modified: bld/namelist_files/namelist_definition.xml modified: src/physics/cam/carma_flags_mod.F90 modified: src/physics/carma/cam/carma_intr.F90
cacraigucar
approved these changes
Jan 3, 2025
cacraigucar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update CARMA base code to the latest tag (carma4_09) and updates existing CARMA models accordingly.
Closes #1181