Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cam6_4_054: Revert t_sfc limiter in RRTMGP #1211

Merged
merged 6 commits into from
Jan 9, 2025
Merged

cam6_4_054: Revert t_sfc limiter in RRTMGP #1211

merged 6 commits into from
Jan 9, 2025

Conversation

nusbaume
Copy link
Collaborator

Reverts the surface temperature limiter used by RRTMGP in CAM, and instead updates the sea ice (CICE) tag to fix the actual cause of the bad surface temperature values in CESM.

Fixes #1185
Fixes #1188

@nusbaume nusbaume added bug-fix This PR was created to fix a specific bug. externals externals updating issue or PR CoupledEval3 labels Dec 22, 2024
@nusbaume nusbaume self-assigned this Dec 22, 2024
@cacraigucar cacraigucar requested review from brian-eaton and peverwhee and removed request for cacraigucar and peverwhee January 2, 2025 21:36
@cacraigucar cacraigucar changed the title Revert t_sfc limiter in RRTMGP cam6_4_043: Revert t_sfc limiter in RRTMGP Jan 3, 2025
@cacraigucar cacraigucar changed the title cam6_4_043: Revert t_sfc limiter in RRTMGP cam6_4_053: Revert t_sfc limiter in RRTMGP Jan 3, 2025
@cacraigucar cacraigucar changed the title cam6_4_053: Revert t_sfc limiter in RRTMGP cam6_4_053?: Revert t_sfc limiter in RRTMGP Jan 3, 2025
@cacraigucar cacraigucar changed the title cam6_4_053?: Revert t_sfc limiter in RRTMGP Revert t_sfc limiter in RRTMGP Jan 6, 2025
@cacraigucar cacraigucar changed the title Revert t_sfc limiter in RRTMGP cam6_5_045: Revert t_sfc limiter in RRTMGP Jan 7, 2025
@cacraigucar cacraigucar changed the title cam6_5_045: Revert t_sfc limiter in RRTMGP cam6_5_054: Revert t_sfc limiter in RRTMGP Jan 7, 2025
@nusbaume nusbaume changed the title cam6_5_054: Revert t_sfc limiter in RRTMGP cam6_4_054: Revert t_sfc limiter in RRTMGP Jan 7, 2025
@nusbaume
Copy link
Collaborator Author

nusbaume commented Jan 7, 2025

Ran the fully-coupled test SMS_Ld2.ne30pg3_t232.BLT1850.derecho_gnu.allactive-defaultio with the surface temperature limiter removed and found that the model crashes as described in the relevant issue. Then ran the same test with CICE tag cesm3_cice6_6_0_6 and found that the test passed as expected. Thus I believe these PR changes work as intended.

@nusbaume nusbaume merged commit 7a90325 into ESCOMP:cam_development Jan 9, 2025
2 checks passed
@nusbaume nusbaume deleted the t_sfc_revert branch January 9, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peverwhee peverwhee peverwhee approved these changes

@brian-eaton brian-eaton brian-eaton approved these changes

Assignees

@nusbaume nusbaume

Labels
bug-fix This PR was created to fix a specific bug. CoupledEval3 externals externals updating issue or PR
Projects
CAM Development
Status: Tag
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nusbaume @brian-eaton @peverwhee