Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve diag salt format #368

Merged
merged 2 commits into from
May 1, 2023

Conversation

jedwards4b
Copy link
Collaborator

@jedwards4b jedwards4b commented Apr 28, 2023

Description of changes

Improve the salt diags, including more significant digits.

Specific notes

Tested using SMS.ne30pg3_t061.B1850MOM.cheyenne_intel
Contributors other than yourself, if any: Gustavo

CMEPS Issues Fixed #367

Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial)

Any User Interface Changes (namelist or namelist defaults changes)?

Testing performed

Testing performed if application target is CESM:

  • (recommended) CIME_DRIVER=nuopc scripts_regression_tests.py
    • machines:
    • details (e.g. failed tests):
  • (recommended) CESM testlist_drv.xml
    • machines and compilers:
    • details (e.g. failed tests):
  • (optional) CESM prealpha test
    • machines and compilers
    • details (e.g. failed tests):
  • (other) please described in detail
    • machines and compilers
    • details (e.g. failed tests):

Testing performed if application target is UFS-coupled:

  • (recommended) UFS-coupled testing
    • description:
    • details (e.g. failed tests):

Testing performed if application target is UFS-HAFS:

  • (recommended) UFS-HAFS testing
    • description:
    • details (e.g. failed tests):

Hashes used for testing:

  • CESM:
  • UFS-coupled, then umbrella repostiory to check out and associated hash:
    • repository to check out:
    • branch/hash:
  • UFS-HAFS, then umbrella repostiory to check out and associated hash:
    • repository to check out:
    • branch/hash:

@jedwards4b jedwards4b self-assigned this Apr 28, 2023
@jedwards4b
Copy link
Collaborator Author

Tested with SMS.ne30pg3_t061.B1850MOM.cheyenne_intel.allactive-defaultio

@jedwards4b jedwards4b requested review from alperaltuntas and gustavo-marques and removed request for alperaltuntas April 28, 2023 19:58
@gustavo-marques
Copy link
Collaborator

Thanks @jedwards4b

@jedwards4b jedwards4b merged commit cf7ec4f into ESCOMP:main May 1, 2023
@jedwards4b jedwards4b deleted the improve_diag_salt_format branch May 1, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the NET SALT Budget table in diags.log
2 participants