Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

long parameter file path string in fates seed dispersal test #2322

Open
rgknox opened this issue Jan 16, 2024 · 1 comment
Open

long parameter file path string in fates seed dispersal test #2322

rgknox opened this issue Jan 16, 2024 · 1 comment
Assignees

Comments

@rgknox
Copy link
Collaborator

rgknox commented Jan 16, 2024

In PR #2265 we attempted to update python test scripting that auto-generates a fates parameter file (nc) by modifying the default file and putting the result in the case directory. The scripting is doing things as intended, but for the FATES PEM seed-dispersal test, the path length to the new file is incredibly long.

Test: PEM_D_Ld15.5x5_amazon.I2000Clm50FatesRs.derecho_gnu.clm-FatesColdSeedDisp.GC.0116-120553de_gnu

Resulting file name on derecho: '/glade/derecho/scratch/rgknox/tests_0116-120553de/PEM_D_Ld15.5x5_amazon.I2000Clm50FatesRs.derecho_gnu.clm-FatesColdSeedDisp.GC.0116-120553de_gnu/case2/PEM_D_Ld15.5x5_amazon.I2000Clm50FatesRs.derecho_gnu.clm-FatesColdSeedDisp.GC.0116-120553de_gnu/fates_params_seeddisp_4x5.nc'

Error:


ERROR: Command /glade/u/home/rgknox/ctsm/bld/build-namelist failed rc=255
out=
err=ERROR : CLM build-namelist::CLMBuildNamelist::process_namelist_commandline_infile() : Invalid namelist variable in '-infile' /glade/derecho/scratch/rgknox/tests_0116-120553de/PEM_D_Ld15.5x5_amazon.I2000Clm50FatesRs.derecho_gnu.clm-FatesColdSeedDisp.GC.0116-120553de_gnu/case2/PEM_D_Ld15.5x5_amazon.I2000Clm50FatesRs.derecho_gnu.clm-FatesColdSeedDisp.GC.0116-120553de_gnu/Buildconf/clmconf/namelist.
ERROR: in validate_variable_value (package Build::Namelist): Variable name fates_paramfile has a string element that is too long: '/glade/derecho/scratch/rgknox/tests_0116-120553de/PEM_D_Ld15.5x5_amazon.I2000Clm50FatesRs.derecho_gnu.clm-FatesColdSeedDisp.GC.0116-120553de_gnu/case2/PEM_D_Ld15.5x5_amazon.I2000Clm50FatesRs.derecho_gnu.clm-FatesColdSeedDisp.GC.0116-120553de_gnu/fates_params_seeddisp_4x5.nc'


When @glemieux first implemented this test, he put the auto-generated file in the srcdir. This works, and we are just reverting to that method in #2265. Ideally we want this file to not be in the source code tree, and somewhere in the caseroot.

Potential solutions are to 1) find ways to reduce the file path length, or 2) to increase the allowable string size.

My current take is that creating the folder "PEM_D_Ld15.5x5_amazon.I2000Clm50FatesRs.derecho_gnu.clm-FatesColdSeedDisp.GC.0116-120553de_gnu" after folder "case2" (which is the second instance of the run when the PE layout changes) is redundant and should be removed if possible.

@rgknox rgknox added the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Jan 16, 2024
@ekluzek
Copy link
Collaborator

ekluzek commented Feb 8, 2024

Talking about this morning we wondered if you could put this under the test root rather than the CASEROOT?

Also the structure of the test with $CASEROOT/case2/$CASEROOT is something that cime does for us. So we can maybe suggest simplifying that, but getting that change into cime would likely be a bigger lift.

@ekluzek ekluzek removed the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Feb 15, 2024
glemieux added a commit to samsrabin/CTSM that referenced this issue Jul 5, 2024
…ramfile in the case directory"

This reverts commit 889cc97.
I forgot that ESCOMP#2322 prevents this from working.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants