Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NEON surface datasets are defined in two places -- should just be one in namelist_defaults_ctsm.xml #2752

Open
1 of 2 tasks
ekluzek opened this issue Sep 10, 2024 · 2 comments
Open
1 of 2 tasks

NEON surface datasets are defined in two places -- should just be one in namelist_defaults_ctsm.xml #2752

ekluzek opened this issue Sep 10, 2024 · 2 comments
Labels
code health improving internal code structure to make easier to maintain (sustainability)

Comments

@ekluzek
Copy link
Collaborator

ekluzek commented Sep 10, 2024 •
edited
Loading

I noticed that the NEON surface datasets are defined both in namelist_defaults as well as in the defaults NEON user mod directory. For code maintenance this should be only in one place and it should be namelist defaults alongside all other surface datasets. This allows updates to surface datasets to just be in one place rather than multiple places.

Definition of done:

  • Do this for NEON
  • Do this for PLUMBER2
@ekluzek ekluzek added code health improving internal code structure to make easier to maintain (sustainability) next this should get some attention in the next week or two. Normally each Thursday SE meeting. labels Sep 10, 2024
@ekluzek
Copy link
Collaborator Author

ekluzek commented Sep 10, 2024

The same should be true of PLUMBER2 datasets.

ekluzek added a commit to ekluzek/CTSM that referenced this issue Sep 11, 2024
@ekluzek
Update NEON datasets, remove double setting of NEON sites in namelist…
65dc3ce 
… defaults and user-mods fixing ESCOMP#2752
@slevis-lmwg slevis-lmwg mentioned this issue Sep 11, 2024
Merged
64 tasks
@wwieder
Copy link
Contributor

wwieder commented Sep 11, 2024

Yes, this would be great, Erik.

@samsrabin samsrabin removed the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Sep 12, 2024
@slevis-lmwg slevis-lmwg mentioned this issue Oct 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code health improving internal code structure to make easier to maintain (sustainability)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wwieder @samsrabin @ekluzek