Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing cleanup from the cesm3_0_beta03/04 "chill" tags for cesm3_0_beta05 #2888

Merged
merged 149 commits into from
Dec 3, 2024

Conversation

ekluzek
Copy link
Collaborator

@ekluzek ekluzek commented Nov 18, 2024

Description of changes

Fix a list of issues mostly for testing that came in with the cesm3_0_beta03 and cesm3_0_beta04 tags for the science "chill" deadline bringing in the baseline science capabilities needed for the cesm3_0 release.

List of things:

  • New polarcap grid
  • Fix use_init_interp for several resolutions that had problems
  • Remove clm5_1 physics option
  • Newly needed surface datasets added to auto build in Makefile for mksurfdata_esmf
  • Fix several individual tests that were failing
  • Update to submodules to ones roughly based on cesm3_0_beta04
  • Add graceful error checking to the FATES parameter file tests that will get it working in some cases

Specific notes

Contributors other than yourself, if any: @slevis-lmwg @adamrher @samsrabin

CTSM Issues Fixed (include github issue #): The individual PR's to this branch have the list of things resolved.
Fixes #2801

Are answers expected to change (and if so in what way)? No

Any User Interface Changes (namelist or namelist defaults changes)? No

Does this create a need to change or add documentation? Did you do so? No No

Testing performed, if any: will do regular testing

adamrher and others added 30 commits August 20, 2024 15:25
Reduce outputs from matrixcnOn tests
doc/ChangeLog Show resolved Hide resolved
@ekluzek
Copy link
Collaborator Author

ekluzek commented Dec 2, 2024

There's something strange in that some things from ctsm5.3.013 seem to show up in this PR.

doc/ChangeLog Outdated Show resolved Hide resolved
doc/ChangeLog Outdated Show resolved Hide resolved
doc/ChangeLog Outdated Show resolved Hide resolved
doc/ChangeLog Outdated Show resolved Hide resolved
Copy link
Contributor

@slevis-lmwg slevis-lmwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ekluzek I requested a few changes to the ChangeLog.

@ekluzek
Copy link
Collaborator Author

ekluzek commented Dec 3, 2024

aux_clm, fates, ctsm_sci testing on Izumi and Derecho are all passing as expected. With the exception of this test:

ERS_L761.1x1_smallvilleIA.IHistClm50BgcCropQianRs.derecho_gnu.clm-smallville_dynurban_monthly (XML)

Which has an XML failure.

@ekluzek
Copy link
Collaborator Author

ekluzek commented Dec 3, 2024

OK, changing that last test so that it's length is 765 rather than 761 gets it to work. So now all of the testing is passing as expected.

doc/ChangeLog Show resolved Hide resolved
@ekluzek
Copy link
Collaborator Author

ekluzek commented Dec 3, 2024

In my local's on Derecho and Izumi, this was correct in terms of having ctsm5.3.013 merged in. So I just remerged in master and pushed it and it then corrected the files here. So that part is resolved now.

There's one namelist test I'm looking at now. But, almost done...

@ekluzek ekluzek merged commit 1d824b8 into master Dec 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bfb bit-for-bit enhancement new capability or improved behavior of existing capability testing additions or changes to tests
Projects
Status: Done (non release/external)
Status: Done
Development

Successfully merging this pull request may close these issues.

fsurdat file needed for NEON MOAB site
4 participants