Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FATES hydro test mod to remove temporary test failure workaround - temp branch PR #2922

Closed
wants to merge 4 commits into from

Conversation

glemieux
Copy link
Collaborator

@glemieux glemieux commented Jan 2, 2025

Description of changes

This PR supersedes #2882 as that PR was set to merge into master and we are currently in a timeframe in which we need to merge into tmp-241219.

Specific notes

See #2882

Contributors other than yourself, if any:

CTSM Issues Fixed (include github issue #):

Are answers expected to change (and if so in what way)?

Any User Interface Changes (namelist or namelist defaults changes)?

Does this create a need to change or add documentation? Did you do so?

Testing performed, if any:
(List what testing you did to show your changes worked as expected)
(This can be manual testing or running of the different test suites)
(Documentation on system testing is here: https://github.com/ESCOMP/ctsm/wiki/System-Testing-Guide)
(aux_clm on derecho for intel/gnu and izumi for intel/gnu/nag/nvhpc is the standard for tags on master)

NOTE: Be sure to check your coding style against the standard
(https://github.com/ESCOMP/ctsm/wiki/CTSM-coding-guidelines) and review
the list of common problems to watch out for
(https://github.com/ESCOMP/CTSM/wiki/List-of-common-problems).

This tag includes the fix to NGEET/fates#1254 and will allow the current
default fates parameter file to be used in fates hydro tests
@glemieux
Copy link
Collaborator Author

glemieux commented Jan 2, 2025

Actually @slevis-lmwg showed me that I can change the base in the original PR, so I'll do that.

@glemieux glemieux closed this Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant