Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read derived variables from other MIP tables #2256

Merged
merged 3 commits into from
Jan 18, 2024

Conversation

bouweandela
Copy link
Member

@bouweandela bouweandela commented Nov 20, 2023

Description

If a derived variable is present in the CMOR tables, but not in the mip specified in the recipe, look it up in other mips. This avoids the need to create custom CMOR tables for such cases.

Updated docs: https://esmvaltool--2256.org.readthedocs.build/projects/ESMValCore/en/2256/recipe/preprocessor.html#variable-derivation


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6e61590) 93.48% compared to head (7da481f) 93.48%.
Report is 25 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2256   +/-   ##
=======================================
  Coverage   93.48%   93.48%           
=======================================
  Files         238      238           
  Lines       12932    12932           
=======================================
  Hits        12089    12089           
  Misses        843      843           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bouweandela bouweandela marked this pull request as ready for review December 12, 2023 09:33
@bouweandela bouweandela added the preprocessor Related to the preprocessor label Dec 12, 2023
@bouweandela bouweandela added this to the v2.11.0 milestone Dec 12, 2023
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, and thanks @bouweandela - glad to see Liza's case taken care of - the only thing I can think of as a potential vulnerability is if the user specifically doesn't want this to happen - maybe add the info (ie derived vars will not be looked up in other MIP tables) to the "CMOR strict" case documentation?

@bouweandela
Copy link
Member Author

add the info (ie derived vars will not be looked up in other MIP tables) to the "CMOR strict" case documentation?

Thanks for reviewing ⭐ I just added a note.

@valeriupredoi
Copy link
Contributor

cheers @bouweandela - spiffy! 🍺

@valeriupredoi valeriupredoi merged commit 9debbbc into main Jan 18, 2024
4 checks passed
@valeriupredoi valeriupredoi deleted the read-derived-tables-from-other-mips branch January 18, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preprocessor Related to the preprocessor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants