-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read derived variables from other MIP tables #2256
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2256 +/- ##
=======================================
Coverage 93.48% 93.48%
=======================================
Files 238 238
Lines 12932 12932
=======================================
Hits 12089 12089
Misses 843 843 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good, and thanks @bouweandela - glad to see Liza's case taken care of - the only thing I can think of as a potential vulnerability is if the user specifically doesn't want this to happen - maybe add the info (ie derived vars will not be looked up in other MIP tables) to the "CMOR strict" case documentation?
Thanks for reviewing ⭐ I just added a note. |
cheers @bouweandela - spiffy! 🍺 |
Description
If a derived variable is present in the CMOR tables, but not in the
mip
specified in the recipe, look it up in othermip
s. This avoids the need to create custom CMOR tables for such cases.Updated docs: https://esmvaltool--2256.org.readthedocs.build/projects/ESMValCore/en/2256/recipe/preprocessor.html#variable-derivation
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: