Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Modify extract_season to return only "full" seasons upon request #2597

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

k-a-webb
Copy link

@k-a-webb k-a-webb commented Nov 29, 2024

Description

Related issue: #2591

Include a parameter full (I'm open to this being a different word) which triggers extract_season to only return "complete" seasons. For example, "DJF" and never just "JF". Invokes extract_time to clip the time vector prior to season extraction

Closes #issue_number


Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.97%. Comparing base (bd617f5) to head (e5c5336).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2597   +/-   ##
=======================================
  Coverage   94.96%   94.97%           
=======================================
  Files         253      253           
  Lines       14701    14716   +15     
=======================================
+ Hits        13961    13976   +15     
  Misses        740      740           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@valeriupredoi valeriupredoi marked this pull request as draft December 3, 2024 17:16
@valeriupredoi
Copy link
Contributor

many thanks @k-a-webb - it's always good practice to have a Draft PR when not ready for review, as you mentioned in the PR title (so I went ahead and made it a Draft for you 👍 )

@k-a-webb k-a-webb marked this pull request as ready for review December 30, 2024 19:59
@k-a-webb
Copy link
Author

@valeriupredoi, could you please help me understand why the pre-commit.ci check is failing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preprocessor extract_season does not return complete seasons
2 participants