Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize input units prior to NCL unit conversion #3228

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions esmvaltool/diag_scripts/shared/scaling.ncl
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,42 @@

load "$diag_scripts/../interface_scripts/logging.ncl"

; #############################################################################
undef("normalize_units")
function normalize_units(units[1]:string)
;
; Arguments
; units: a string of units that will be normalized.
;
; Return value
; A string of normalized units.
;
; Description
; Normalize units, i.e., split units by ".", sort them, and return
; concantenated units (by " "). Example: "m-2.kg.s-1" -> "kg m-2 s-1".
;
; Modification history
; 20230614-schlund_manuel: written.
;
local funcname, scriptname, split_units, concatenated_units
begin

funcname = "normalize_units"
scriptname = "diag_scripts/shared/scaling.ncl"
enter_msg(scriptname, funcname)

; Split units by "." and sort if necessary
split_units = str_split(units, ".")
if (dimsizes(split_units).gt.1) then
sqsort(split_units)
end if

; Concatenate with seperator " "
concatenated_units = str_join(split_units, " ")

return(concatenated_units)
end

; #############################################################################
undef("convert_units")
function convert_units(var:numeric,
Expand Down Expand Up @@ -64,6 +100,9 @@ begin
return(out)
end if

; Normalize source units
units_from = normalize_units(units_from)

if (units_from.eq."1") then
if (units_to.eq."g/kg") then
out = out * 1000.
Expand Down