-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a realistic example recipe #3356
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Only thing we might still want to add is some documentation (including the nice output figure). Perhaps under https://docs.esmvaltool.org/en/latest/recipes/recipe_examples.html, or do you think it should be added under https://docs.esmvaltool.org/en/latest/recipes/index.html#ipcc? Let me know if I can help with that.
434cabf
to
99ec013
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, this seems complete to me now 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
top job, fellas! 🍺 Tho sad to see a "realistic" example recipe taking 5 hours 😁
Over the coming year we will get support from the ESiWACE3 project to make it faster, so if things go according to plan it should be a lot faster soon 🚀 |
Description
Add an example recipe that reproduces part of figure 9.3a from IPCC AR6. This is the figure produced by the recipe:
To run the recipe, use the ESMValCore development version
main
branch or the upcoming [v2.10 release] once it is available.I used these settings for the Dask distributed scheduler:
~/.esmvaltool/dask.yml
:batch job
and the run took about 4.5 hours. Running with
--max-parallel-tasks=1
is required to avoid overloading the Dask scheduler with too many tasks. As it is, the Dask graph for computing a single output file contains almost 800K tasks. See SciTools/iris#5455 for a discussion of some of the computational performance issues.Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
New or updated recipe/diagnostic
To help with the number of pull requests: