SHL, SHR, SAR, and related tests #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
whilei
reviewed
Sep 12, 2018
src/patch/mod.rs
Outdated
| @@ -177,6 +181,7 @@ impl Patch for EmbeddedByzantiumPatch { | |||
| fn has_static_call() -> bool { true } | |||
| fn has_revert() -> bool { true } | |||
| fn has_return_data() -> bool { true } | |||
| fn has_bitwise_shift() -> bool { false } | |||
There was a problem hiding this comment.
This Patch should be EmbeddedConstantinoplePatch, or?
There was a problem hiding this comment.
Oh. Dunno what I did, but my comment just got removed.
Patch name is OK here, but I gotta add an EmbeddedConstantinoplePatch indeed
There was a problem hiding this comment.
Actually decided to remove the EmbeddedByzantiumPatch: #353
|
Oops, forgot to update the |
mersinvald
force-pushed
the
shift-opcodes
branch
2 times, most recently
from
bdfd39b to
90dba02
Compare
whilei
approved these changes
Sep 17, 2018
r8d8
suggested changes
Sep 17, 2018
mersinvald
force-pushed
the
shift-opcodes
branch
2 times, most recently
from
638d4cc to
a1136d5
Compare
|
@r8d8 working on it |
mersinvald
force-pushed
the
shift-opcodes
branch
2 times, most recently
from
8c9bf35 to
b933b0b
Compare
r8d8
approved these changes
Sep 21, 2018
mersinvald
force-pushed
the
shift-opcodes
branch
from
a66bb33 to
0395632
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds related Constantinople opcodes.
Issue: #350
Main question is how do we approach merging that?
Feature-by-feature or one big PR with all Constantinople changes included?
@whilei
Closes #350