Refactoring iso15118 EVerest types #1050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebaLukas
requested review from
corneliusclaussen,
Pietfried,
hikinggrass,
maaikez,
james-ctc,
a-w50,
MarzellT and
andistorm
as code owners
|
Looks good! For 2.1, it's better to share types than to have them defined in 2 places. |
AssemblyJohn
approved these changes
Feb 14, 2025
SebaLukas
added
the
post-release
Pietfried
requested changes
Feb 14, 2025
SebaLukas
force-pushed
the
refactor/iso_types
branch
from
c52a3b1 to
aa80f05
Compare
Pietfried
approved these changes
Feb 14, 2025
MarzellT
approved these changes
Feb 14, 2025
|
|
SebaLukas
force-pushed
the
refactor/iso_types
branch
from
aa80f05 to
02095a4
Compare
- Renamed iso15118_charger type file to iso15118 - Adding generated iso types for OCPP2.1 - Refactored the enum types - Removing ChargingSchedule type - Spelling mistakes changed - clang-format Signed-off-by: Sebastian Lukas <[email protected]>
SebaLukas
force-pushed
the
refactor/iso_types
branch
from
02095a4 to
25d90c5
Compare
Signed-off-by: Sebastian Lukas <[email protected]>
corneliusclaussen
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
iso15118_charger+iso15118_evinto oneiso15118type.ChargingNeedstype for OCPP 2.1Issue ticket number and link
For OCPP 2.1 we need some information from the ev. So we added these types to the iso15118 everest type yaml file.
Checklist before requesting a review