Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Allow to link against GCOV #614

Merged
merged 3 commits into from
Apr 5, 2024
Merged

Conversation

dorezyuk
Copy link
Contributor

@dorezyuk dorezyuk commented Apr 2, 2024

When we build with BUILD_TESTING, we're adding the flags for gcov and need to subsequently link against gcov. This commit fixes the behavior for rust

See EVerest/everest-framework#171

@dorezyuk dorezyuk force-pushed the fix/rust_link_gcov branch from db4b2c2 to 75586f2 Compare April 2, 2024 11:24
@dorezyuk dorezyuk marked this pull request as draft April 2, 2024 11:24
Dima Dorezyuk and others added 2 commits April 5, 2024 14:55
@dorezyuk dorezyuk marked this pull request as ready for review April 5, 2024 12:58
Copy link
Contributor

@golovasteek golovasteek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hikinggrass hikinggrass merged commit 75cc247 into EVerest:main Apr 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants