Adding start and stop transaction powermeter cmds to the JsDCSupplySimulator module #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pietfried
approved these changes
Apr 8, 2024
|
In commit message and PR description: "DCSupplySimulator" -> "JsDCSupplySimulator" BTW, the former did not obsolete the latter because the latter also provides a |
SebaLukas
changed the title
|
Thank you for noticing. I changed the title and the description with the correct JsDCSupplySimulator module. The cpp DCSupplySimulator module does not currently provide the powermeter interface. That is why I have not added the changes to the cpp module. |
…lator module Signed-off-by: Sebastian Lukas <[email protected]> Signed-off-by: pietfried <[email protected]>
SebaLukas
force-pushed
the
fix/adding_transaction_to_dcpowersupplysim
branch
from
1a4b66c to
10c3157
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Adding start and stop transaction powermeter cmds to the JsDCSupplySimulator module
Issue ticket number and link
#624
Checklist before requesting a review