Fix unchecked optional access in Charger.cpp #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eter * Moved ownership of session_uuid to Charger class * Using proper arguments in call_start_transaction and call_stop_transaction of powermeter Signed-off-by: pietfried <[email protected]>
|
@golovasteek : FYI. Not sure if the changes are relevant for your platform |
Signed-off-by: pietfried <[email protected]>
dorezyuk
reviewed
Apr 11, 2024
dorezyuk
reviewed
Apr 11, 2024
dorezyuk
reviewed
Apr 11, 2024
dorezyuk
reviewed
Apr 11, 2024
dorezyuk
reviewed
Apr 11, 2024
* moved generate_session_uuid outside Charger class * made get_session_id const * using string clear func Signed-off-by: pietfried <[email protected]>
corneliusclaussen
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Checklist before requesting a review